I think this settings page really needs some fixes...
# proj-agent-canvas
l
I think this settings page really needs some fixes: 1. a one-word link next to a button (looking more like an entry rather than a link) 2. an input box that doesn't look like an input box (same background as the page, you can't even see the blinking cursor because it doesn't get focus by default) 3. an "Edit Configuration" button that changes to "Cancel" despite an "Apply Changes" button being present below
e
@breezy-kilobyte-39430 has some nice changes coming to settings
👍 1
l
I've fixed it up a little anyway. Can submit PR if the settings UI refresh isn't coming soon.
f
Feel free to open a PR, it might take a little while until we apply Paul's changes
e
Thanks @little-architect-38123 !
🙏 1
l
Ok. I'll open a GH issue first because I found some other problems while testing the changes. 4. If you press F5 on the MCP settings page, the settings won't load (no entries, the editor will show default values). If you click on another tab and then back on MCP, they load fine. 5. There are both an "Apply changes" and a "Save changes" (main settings UI) button. "Apply" doesn't actually apply anything, since nothing is saved without the other button, and that's a bit confusing. 6. The default values are localized, which makes no sense (it's JSON, can't have comments = nothing to localize). 7. Both the docs and the default values mention an 'shttp_servers' key, but it's not present in the editor example, nor in the localized defaults. Still, I've seen it appear, so I suspect the settings are modified at runtime. It either needs to be added as a valid key or removed completely if unsupported. 8. The docs linked in the settings page aren't very helpful: they only show config.toml examples. My PR should fix half of these issues (1-3 and 5, where I just changed "Apply" to "Confirm"). Sorry about the others, but I ran into them too late. Also hope my PR is tested before merge, just to be extra-sure, since I don't have an MCP server set up yet.