another one adressing <@U02AYM7HVR7> lower case PR...
# sarek_dev
r
another one adressing @Adam Talbot lower case PR from ages ago: github.com/nf-core/sarek/stack/2415 1. Remove when’s where we can 2. Fix all stray params.tools calls in configs or .nf files 3. add the lower case check. I played around here a bunch with using a function from a groovy vs what I implemented now. Reason I went for this, it;s simple, easy to read, and it looks the same in the config and the nf files. I couldn’t call the groovy function in the config, so it ended up with a bunch of ugly conversion afterall
merged 1
a
Want a review?
done anyway - general feedback, I would turn
tools
and
skip_tools
into a
List[str]
earlier and then test for tool presence or absence outside the subworkflows
r
if you have time, it’s not very urgent, just picked it up in between
a
Side note, could we turn tools into a record?
Copy code
record Tools {
    tool1: Bool
    tool2: Bool
    // etc
}
And then we can do
if tools.tool1:
(later versions, not now)