Backlog PRs from the release block for review pre...
# sarek_dev
r
Backlog PRs from the release block for review pretty please please: • github.com/nf-core/sarek/pull/2401/changes (template update, if someone can double check the rocrate update) • github.com/nf-core/sarek/pull/2402 Add Deepsomatic model ffpe. • github.com/nf-core/sarek/pull/2395/changes Trigger tests of the corresponding modules config changes • github.com/nf-core/sarek/pull/2391/changes Make lane optional in samplesheets collected the last three in a stack so they can go in at once: github.com/nf-core/sarek/stack/2404 I will then review these: • github.com/nf-core/sarek/pull/2389 Controlfreec without sex information • github.com/nf-core/sarek/pull/2161/changes xengsort And work on: • github.com/nf-core/sarek/pull/2392 think about the lower case PR. It’s more tricky than I thought. • github.com/nf-core/sarek/pull/2353 Wrap up the PB haplotypefiltering.
m
for me the rocrate is only an issue if linting complain, and if so, I grab it from dev, and I regenerate based on what we have on the PR itself
r
ah sorry wrong link I had accidentally opened it from my fork and then moved. correct link is in the stack. and here: github.com/nf-core/sarek/pull/2402
m
stack was closed when I checked
This stack has been deleted.
r
I need coffee
f
I had an idea regarding the FFPE
commented on the PR
r
replied. Tl;dr: deepsomatic is the only one with an FFPE mode. I checked all other callers
f
I think for freebayes we could for example adjust the standard settings a bit more based on that
its not always a “mode” but something that could influence base settings reasonable defaults
happy to ask in #CGFUX04HZ maybe there are some users that have their specific configs for that? would it be ok to do that first and if no one replied we leave it at deepsomatic?
I think the PON can also be influenced by FFPE (but not sure about this)
r
we don’t generate the PON so whatever people do there in #C05GH685FKJ is out of our control. I don’t see any guidance in the freebayes docs: github.com/freebayes/freebayes do you have more info there?
👍 1
f
freebayes docs are horrible 😞
m
What do you want to do in createpanelrefs?
Do I hear you want a rust rewrite of freebayes?
r
you are on your own I think 😆
🤣 1
the rewrite doesn’t change non-existent FFPE guidances
What do you want to do in createpanelrefs?
nothing really. Just flagging that we are not generating the PON, so setting FFPE settings for PONs is the producers responsibility (ideally of course #C05GH685FKJ)
m
We could add such a flag if there something that exist
We need the meta subway map
f
I am doing some lookup with gemini into FFPE optimization and I just think we can do better and apply it where we think it fits
r
ok let me know what you find. my stance is generally to be fairly careful with changing the default parameters unless there is an explicit call out from the tool developers for certin scenarios
f
I just did a very brief sweep nothing conclusive yet and I understand your hesitation but I think having the ffpe flag would make sense since its so widely used and I just do not want to add this singular flag only to remove it later? Maybe it also makes sense to have the type of sample prep in the sample sheet (not sure abou that though). But also its a #C078586GZ5X and i think you can go ahead for now since its pretty clear for deepsomatic
r
can you please have your agent add the sources where this information is retrieved from
👍 1
f
yes I will spend some more time on that to be conclusive 🙂 so from my side good to go for now
r
I can let this PR be for a few days, I should try to merge it by tuesday latest
👍 1
f
I will not have enough time until then 🙂 I would say go ahead and if I find somethinhg we discuss it later
r
ok let’s leave for monday meeting to discuss though
m
Sounds good
r
will remove it from the list so the rest can get in