Hello I’m working on adding Binette as a second bi...
# mag
j
Hello I’m working on adding Binette as a second bin refinement option (see issue here https://github.com/nf-core/mag/issues/714). I have a quick question on the parameter design: • Option A: replace
--refine_bins_dastool
with
--refine_bins_tool dastool|binette
. It’s cleaner, especially if another refiner gets added later (MAGScoT was suggested in https://github.com/nf-core/mag/issues/1131). It’s a breaking change though,
--refine_bins_dastool
needs to be deprecated. • Option B: add a
--refine_bins_binette
mutually exclusive with
--refine_bins_dastool
. Nothing breaks. Do you have any preference ? We could also chain them (DAS Tool then Binette, or the other way round), but that feels a bit sketchy and adds extra complexity.