https://nf-co.re logo
Join Slack
Powered by
Hi, we need to do a template update on our pipelin...
# nostupidquestions
l
Hi, we need to do a template update on our pipeline but we muddled it up a little and now we can’t merge the PR. Could anyone help us with the best way to move forward? github.com/nf-core/genephylo/pull/17
👀 1
m
you need to push a snapshot
you have a failure for now, because tests are running but cannot compare with anything
I’d recommend trying to run the test locally (or on codespaces) once
don’t hesitate to shout out if you need more help/guidance on that
l
how do I get this snapshot? i tried running nf-core pipelines sync, which I assume would create the snapshot, but it failed with an error about manifest.name
m
I usually get them via running nf-test, with something like:
Copy code
nf-test test --profile=+docker --verbose --update-snapshot tests/
Oh but wait
You’re making a PR to TEMPLATE
sorry, totally misread the situation
I thought it was a template sync
l
Yes, I think what we should have done is a template sync, but like I said, we made a bit of a mess 😅
m
yeah, no worries
I think we can do without that then, let me check with @mashehu, but I think we can do the force push ourselves and bypass this PR
l
thanks! my understanding is that, once we publish the first version of the pipeline, the template updates will be automatic, is that the case?
m
yeah, was looking into this now and the problem is that we don’t do automated template syncs for ignored repos https://github.com/nf-core/website/blob/main/sites/main-site/src/config/ignored_repos.yaml will need to fix that logic
easiest would be if you say you are in a state where you can have a website for the pipeline on nf-co.re and then we can just remove it from that file
otherwise I am working now to fix the logic there, but could take a bit
l
I’m aiming to have a first version published by the end of the month, so that should hopefully fix the situation
but as of now, no, I can’t really say we have anything remotely looking like an actual pipeline 😒
m
if it is in that state, I think it is fine to have the website already (we usually just try to avoid collecting to many abandoned pipeline pages on the website)
💯 1
l
if that’s good enough for you guys I have nothing against it of course deal with it parrot
m
aggreing with Matthias, if you aim for a release by EOM, I think you’re comitted enough for a website
l
not sure if the timeline will be respected, but that’s the goal yeah, because I for once have a few weeks free of other commitments and so I want to focus on this so it’s finally done
m
So speaking from personal experience, it will not get respected
😆
l
i am relatively convinced of that as well
m
Any release is hard to get in time, mainly because so many things depends on other people and just not you
but it’s always good to plan
l
mostly it’s just to motivate myself to work on it, I work better with a deadline
and now it’s official with you guys so hopefully that will also trick my brain into a sense of urgency 🤷‍♀️
m
shout if you need any help pushing things along then
💯 1
m
I try to get past that, but I think I am quite similar. Anyhow, please never hesitate if you need some code reviews, or anything we can do to help you
l
thanks! will ping if needed
m
m
so we can close 17, right?
l
I think so? I’ll do the conflict resolution on 18 and merge, and close 17.
👍🏻 1
🎉 1
Open in Slack
Previous
Powered by