Hi guys. Are some CI-tests failing on the `dev` -b...
# sarek_dev
a
Hi guys. Are some CI-tests failing on the
dev
-branch? After merge of
dev
into my branch, the CI-tests started failng.
image.png
That kind of error doesn’t seem related to the code-updates in the PR 🤔
r
can you merge in dev. this looks llike your PR is missing the template update PR that bumped the fastqc version
ah no I know why. @Maxime Garcia I think the umi PR had passing tests, didn’t merge in dev (cause no merge conflicts), but created it’s snapshots and usccesful test rnus before we had bumped fastqc on dev
two options, either you fix the snapshot or we open a separate PR for that. let me do the second quickly, we need to fix sth else in that UMI PR as well as a follow up
a
I see. I prefer that you fix the snapshots, and then I can again merge
dev
into my branch 🙂
m
Oooh
sorry about that
facepalm
r
no worries, it would be nice if github would flag this actually. “Hey dev had merges and test changes, you may want to rerun”
party this 1
@Anders Sune Pedersen PR is merged in dev now