Hi, I opened <github.com/nf-core/sarek/pull/2361> ...
# sarek_dev
s
Hi, I opened github.com/nf-core/sarek/pull/2361 TMB with pyTMB on Mutect2 calls annotated with snpEff, towards github.com/nf-core/sarek/issues/495 and picking up github.com/nf-core/sarek/pull/616. It is my first sarek PR, so the CI runs need a maintainer's approval. Happy to change the approach if it should be done differently. Thanks!
๐Ÿ‘€ 1
r
It should work without. are you a member of the nf-core org?
if not, please go to #CEB982K2T to be added ๐Ÿ™‚
I triggered them for now though
s
Thanks Rike! Joined the org now, and CI is green apart from Sentieon (no secrets on forks). No rush at all on my PR, whenever someone has time to look.
r
the PR looks pretty good at first glance. I will do a bit deeper review tmrw. The annotation stream has a few particularities, so just want to make sure all the right things are included/excluded in the channel wiring
Thanks a lot for tackleing this, itโ€™s been an ancient request