Hi! I'm working on updating the modules to use Seq...
# funcscan
p
Hi! I'm working on updating the modules to use Seqera containers. I got a problem with the amrfinderplus_run module. I raised an issue in funcscan as that is where it used. I thought I'd let you know: github.com/nf-core/funcscan/issues/558
👍 2
j
Thank you @Pauline Fourgoux! It's actually a bit weird... I'm confused how that module is working then in our pipelien as we odn'th ave those
meta
fields 😅
but the fixes you are making are correct!
Oh wait it only injects if the
meta
fields are in otherwise gets ignored - so all fine for us regardless 🙂
p
Hi @James Fellows Yates, how do you want me to proceed? Should I update the module and then let you update funcscan or do you want me to do a PR for funcscan too?
j
If you could do both that would be awesome but we can also do it ourselves when we soemone gets a bit of free time :)
p
I'll try to do it this week while I have it in mind. I'll update you here!
❤️ 2
c
This would be great, thx for taking this on @Pauline Fourgoux!
❤️ 1
p
I have the PR ready in modules github.com/nf-core/modules/pull/13553 not sure if one of you can approve? I've been updating quite a few modules today and spamming a bit the modules team at the moment 😂
c
I added both James and myself
❤️ 2
I approved it, looked pretty straightforward!
You have been busy!
p
Yes it is!
I've been a bit avoiding doing my day job today. I preferred being productive by doing some nf-core instead of scrolling
😆 1
j
I've been a bit avoiding doing my day job today. I preferred being productive by doing some nf-core instead of scrolling
Careful... It can become addictive
😂 1
amaze 1
c
Since there is a PR for funcscan addressing this I also added @Olga Brovkina and myself to assist w/ review
❤️ 2
👍 1