Cleaning up some mutectcaller bits <github.com/nf-...
# sarek_dev
r
Cleaning up some mutectcaller bits github.com/nf-core/sarek/pull/2348 i think then we can merge github.com/nf-core/sarek/pull/2180 nd I can fast follow a PR that fully integrates the filtering
checked 1
merged 1
m
you seem to have issue with GPU tests
r
yep not sure why the logging changes
regenerating again
ok I think I had some weird local settings from playing around sth else around verbosity and surpressing logs
m
agents might be running nextflow and nf-test in agents mode, and don't get all output the right way
I have noticed such weird stuff
r
yeah I am trying to figure ot if I can force it not to use those flags, it's very annoying
do you want to review this one: github.com/nf-core/sarek/pull/2180/changes I reviewed a few times, but now I also contributed quite a bit to it
👀 1
m
commented, but ok to merge as is
r
moving discussion here: I don't think we should merge the subworkflows because parabricks has no scatter/gathering logic and doesn't support a number of thins mutect does like joint calling
m
I was more thinking merge the 2 pb_mutect 2 subworkflows in one
they look fairly similar
I do not want to cram pb_mutect2 and mutect2 in one subworkflow, apart from the one we have to do all variant calling
My aim here is just avoiding code duplication
r
ahhh yes, let me take a look at that.
The link to the module confused me
m
sorry
r
ok this is easy, so will add it to the PR. I am in parallel exploring the filtering where it may get more complicated again, but I will handle that on the filtering PR
👍 1
Done.