Hi all, as some of you noticed, I have tried to ru...
# pipeline-maintainers
d
Hi all, as some of you noticed, I have tried to run my tool to resolve the template updates without conflicts. In the process, I have created pairs of stacked PR drafts; I intend to curate them in the coming days. I have done this work earlier with good feedback from the community, yet this time I've noticed that it has brought a lot of confusion. Context - what is the goal Template updates have been relying on exact matches, not intentions. The best example would be YAML patching, which would be error-prone; however, we can instead describe exactly the core migration by knowing its structure (ex. update property
foo.bar
with value
baz
). I will not attempt another wide-scale update, and it is fair to close those draft PR. For the ones that will remain open, I will keep working on updates and request reviews (move things from draft) once I deem them ready.
thanks 2
j
Feel free to approach a few pipelines of your choice to see if they would volunteer to be used as testers :)
In most cases people will say yes; but like myself this morning it is very confusing to get like 12 GitHub notifications of PRs being merged I didn't recognise 😅
party this 3
Thank you for notifying here too :)
d
Yes, I am sorry about that. Didn't count the human factor - will surely take some teaching from this experience
❤️ 1
n
While I was also pretty confused what was going on, I am not very keen on doing template merges, so feel free to experiment on #C038XMTQWBT and ping me when I should take a look at something
j
@Dominik Maszczyk I think its a very nice approach to help maintaining nf-core pipelines, thanks for the work! Since this is now announced (I guess we will also mention in nf-core/maintainers meeting) its fine from my side. I guess maintainers were confused since the repo is not under the nextflow/nf-core umbrella (yet) and I am worried about PRs altering github actions from not verified sources 😁 . Just ping the codeowners/maintainers of the respective pipeline for a review before merging. Feel free to experiment on #CE9BJ6X6V #CED0U30KD #CFVDZCA23
👍 1
s
Hi! I was already working on fixing the conflicts, but I can wait before merging it in case viralrecon is usefull for you!
d
@Sarai, it’s all right; please don’t wait for my version. I still have some tests failing, and I believe you’ll be able to get the solution working before I can get back to it.
On a more general note, this is a voluntary side hustle for me, so I might not be able to address all the feedback right away, but I've queued it all, and it is not going to be forgotten.
s
Perfect! Thank you! Just let us know if you ever need to use the pipelines for testing your tools or need some feedback! 😊