https://nf-co.re logo
Join Slack
Powered by
Teenie tiny bulk PR for samtools modules <github.c...
# request-review
m
Teenie tiny bulk PR for samtools modules github.com/nf-core/modules/pull/13473 Mostly green, just waiting for the bot to update GPU snapshots
✍️ 1
And another teeny tiny bump for bcftools github.com/nf-core/modules/pull/13480
👀 1
Since nf-core-bot seems to be having an extended lunch, is there anyone with access to an nvidia GPU that can update the remaining snapshots here? github.com/nf-core/modules/pull/13473
m
just checked in the workflow file. I guess the syntax is to point to the test directory not the test file
m
facepalm
Docs say full path to test file
m
looks like whoever updated it ignored that
old man yells at claude
😅 1
m
I opened a PR to edit the update job
If you don’t mind giving it a look
m
already looking at it
m
Awesome
the gist is (or should be) the user can use wildcards or nf-test tags to select which snapshots should be updated
To avoid melting icebergs with extra CI runs
m
yep, I like the idea
m
Seems like the bot is ignoring you too though 😄
Is this the beginning of the uprising?
m
not ignoring, failing because we have a too strict capture of the snapshot fail (it looks for 
<http://main.nf|main.nf>.test.snap
instead of 
<http://gpu.nf|gpu.nf>.test.snp
m
Those are some nice docs
m
m
It’s working!
m
kind of
(but we had that also before)
m
As long as I get my snapshots I’m happy 😄
I think we’re going to need to update the logic some more. Running way too many tests when relying on just a tag
m
canceling it now until we have https://github.com/nf-core/modules/pull/13484 in place
✅ 1
m
Didn’t work, everything is skipped now
Seems to work when you give it a path
including the reaction
m
looks like there was a double space after 
@nf-core-bot
breaking the first check. could run it succesfully with tag https://github.com/nf-core/modules/actions/runs/40726702405/job/122951908545#step:4:52
m
Open in Slack
PreviousNext
Powered by