Can I bump the following minor tools changes: - fi...
# request-review
a
Can I bump the following minor tools changes: • fix tool/subtool clashes in local `module create`: github.com/nf-core/tools/pull/4552 • fix tool/subtool name matching: github.com/nf-core/tools/pull/4556
m
Yes, I will have a look today. Wanted to first be sure we didn't need a 4.2.2 🙂
👍 1
can you please allow me to push to your PR https://docs.github.com/en/pull-requests/how-tos/work-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork (I think i found a simpler way by simply treating "local" as an org name)
a
I considered that, because
_init_nfcore_component
would then get the correct folder, but I think it would be a sort of bodge treating the component as a remote
nf-core
module with an
org==local
. This is part of a stepping stone towards handling local modules so I can work on #4508. I’m kind of wary of using
org
outside of a modules repo
Also
module containers
doesn't actually subclass component command I think?
m
yes, reverted some changes now, but also simplified your tests
a
Should be able to push to the fork now
👍🏻 1