Small fix for parameters from string to integer in...
# request-review
d
Small fix for parameters from string to integer in metatdenovo: github.com/nf-core/metatdenovo/pull/598
quick look 1
✅ 1
d
This sounds like it could be worth a patch release. A bit complicated since one can't just take the full
dev
branch which includes parts that we'd like to release with other things that are not yet done.
Do we need to fix #C01U1E95JQ5 too?
d
I will check it but probably there is the same issue there
d
I'm looking into it now because I remembered there are two ways of addressing this. That also lead to me looking for other cases that don't work. I just posted a request changes review -- sorry! The best way, IMO, to fix this is with a
params
block in
<http://main.nf|main.nf>
in which numerical and boolean params are declared. The advantage of this is that you don't have to remember to type cast params when you use them. Since Nextflow 26.10 one also has to think about adding a
?
to non-mandatory params, e.g.
trim_nextseq: Integer?
. This requires us to bump Nextflow to 26.04. For the patch releaes, you can choose if you want to do the type casting in
modules.config
(adding the params that are not yet handled, see my review comment) or add a
params
block in
<http://main.nf|main.nf>
. I can do a PR for magmap right away that you can use as an example.
That example is now in github.com/nf-core/magmap/pull/287
🙌 1
d
Right. I can implement the same in metatdenovo then