```This PR exceeds the recommended size of 1000 li...
# team-maintainers
e
Copy code
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
Should we remove this check from the modules repo? With the conda locks every PR is more than 1000 lines now.
a
Or maybe increase the limit?
j
We can skip conda lock files from the check, it’s a feature of the GHA.
πŸ‘πŸ» 1
πŸ‘ 2
p
Along the lines of "possibly needlessly complicated, but still elegant, kind of" would be to have a previous step checking through
.gitattributes
for
linguist-generated
(which seems to be exactly the conda-lock files for now, see above) and feed that to pr-size-labeler as
files_to_ignore
in a suitable form.
🀩 2
m
I like that idea
It seems slightly over-engineered, but yet simply elegant in a way
that is a nice balance
j
Only concern with that is that the
.gitattributes
file uses
**
globbing but the GHA wants Bash-style globs, which only accept a single
*
. So you would need to figure out how to translate one to the other