<#2321 mag: add bins and samplesheet for testing -...
# test-data
g
#2321 mag: add bins and samplesheet for testing --bins_input Pull request opened by erikrikarddaniel Adds four MaxBin2 bins (
bins/
) and
samplesheets/bins_samplesheet.csv
, with README entries. They are used by a new
test_bins_input
profile in nf-core/mag, which starts the pipeline from pre-computed bins (
--bins_input
, see nf-core/mag#623). 🤖 Generated with Claude Code https://claude.ai/code/session_01NJ75Ui2JZjJwJ7T7o5acvg nf-core/test-datasets
Review on #2321 mag: add bins and samplesheet for testing --bins_input Review comment by piplus2 on erikrikarddaniel's pull request Hi @Daniel Lundin, thanks for this, it's nice to see
--bins_input
getting test data! 🎉 I checked the four bins. They're all valid gzipped FASTA, about 830 KB in total (61, 154, 29 and 117 contigs), so they're well within the size we want for test data. The layout fits the existing branch too: a top-level
bins/
next to
assemblies/
,
bins_samplesheet.csv
named like
assembly_samplesheet.csv
, and the same
github.com/nf-core/test-datasets/raw/mag/...
URL style. Thanks for documenting them in the README as well 🙏 A few small things: 1. The
group
column
: all four bins are in group
minigut
, but the README says they come from two samples (
test_minigut
and
test_minigut_sample2
). If one group is deliberate (for example, so dereplication clusters the two near-identical bins), could you add a sentence saying so in the README? If not, should the
test_minigut_sample2
bin get its own group? 2. Bin naming: the MEGAHIT bins are called
MEGAHIT-MaxBin2-minigut.*
, while the SPAdes ones keep the full sample name (
SPAdes-MaxBin2-test_minigut.*
). Were the MEGAHIT ones renamed, or do they come from a different run or a co-assembly? A short note on where they came from (pipeline version and profile) would help anyone who needs to regenerate them later. 3. Samplesheet schema: I couldn't find the nf-core/mag PR that adds
--bins_input
yet (#623 is still the feature-request issue). Once it's open, could you link it here? That way we can check that
group,fasta
matches the pipeline's input schema before merging. 4. Tiny nit (optional): the new README line says "Samplesheet", while the line above it says "Sample sheet". Feel free to ignore. Nothing here blocks the PR. Happy to approve once the schema is confirmed against the mag PR 🚀 nf-core/test-datasets
Review on #2321 mag: add bins and samplesheet for testing --bins_input Review approved by piplus2 on erikrikarddaniel's pull request Approving so this isn't held up 🚀 Please address the points in my review above before merging, especially checking the
group
column and confirming that the
group,fasta
samplesheet matches the
--bins_input
schema in the mag PR. Thanks again @Daniel Lundin! nf-core/test-datasets