Small pattern change for chromosome names
<github....
# request-reviewl
Louis Le Nézet
09/22/2026, 12:30 PMSmall pattern change for chromosome names
github.com/nf-core/phaseimpute/pull/314
✅ 1
s
Sébastien Guizard
09/22/2026, 12:32 PMDone!
l
Louis Le Nézet
09/22/2026, 12:35 PMThanks, I left a small comment on yours, but happy to approve otherwise
s
Sébastien Guizard
09/22/2026, 12:36 PMTBH, I beleived tqht the 4.1.0 template were already merged with the 3.0.0 release of yesterday.
I have noticed few changes at merging, so I guess it needed to be done anyway.
l
Louis Le Nézet
09/22/2026, 12:39 PMAfter checking, it seems you push to the dev branch without PRs and you merged the TEMPLATE on august 14.
s
Sébastien Guizard
09/22/2026, 12:42 PMHow could I do that 🤔
Sébastien Guizard
09/22/2026, 12:42 PMOh OK I see
Sébastien Guizard
09/22/2026, 12:42 PMI have done it outside the PR
Sébastien Guizard
09/22/2026, 12:43 PMWhich might explain the problem I had the conda locks.
Sébastien Guizard
09/22/2026, 12:44 PMCompleting the PR will make thing clean
Sébastien Guizard
09/22/2026, 12:46 PMThanks for the approval! And nice catch!
l
Louis Le Nézet
09/22/2026, 12:48 PMYou're welcome !