Support gzipped input files in phyloplace: <github...
# request-review
d
Support gzipped input files in phyloplace: github.com/nf-core/phyloplace/pull/95
✏️ 1
I'm following your suggestion @Jonathan Manning. One catch-all PR to modules and I'll ping you for a review?
👍 1
This wasn't as easy as I thought. There's an open PR with a bit of discussion for one of the modules (github.com/nf-core/modules/pull/12894). I don't want to step into that, so I'm keeping the patch for that. The other modules have a PR in: github.com/nf-core/modules/pull/12991 Absolutely no hurry, have a nice weekend! 🙂
j
Yep, sorry, got a big late meeting shortly, won't get to it today, will get to it next week. Have a good weekend too!
Seem's like Simon's got you covered on 12894, once the python script is removed. Just a minor comment on 12991.
d
Yes, I've seen the discussion on 12984. It was first included in my 12991 until I remembered and broke that out. Thanks for the approval, I'll get your comment addressed.
Would you mind having another look at github.com/nf-core/phyloplace/pull/95? The updated modules are now pulled in. (I'm skipping 12894 until it's merged upstream).
✏️ 1
Thanks @Jonathan Manning. Here's a modules PR for the last two patches of the pipeline: github.com/nf-core/modules/pull/13005
✅ 1