Dear all, I started to update a few sentieon modules, then I thought of updating them all. Besides a flaky

sentieon/rsemcalculateexpression

test, updating

sentieon/rsemcalculateexpression

opened up a bigger question: the linter raised an

Invalid 'meta' keys detected: meta.strandedness

error, so I tried to make

strandedness

a parameter. I updated the tests accordingly. However, this module is used in a nf-core subworkflow, which now (understandably) complains about the change in number of parameters. Is a

strandedness

value channel even desirable? How would the community approach these issues?

My understanding was that no assumptions should be made by modules about the keys in meta, besides the existence of

id

.

Thanks, Niklas!

The maintainers are also now having another discussion about meta.strandedness. It may be allowed again at some point, so you may be able to get a maintainer to force merge the PR for you ( so you don't have to address the meta.strandedness issue )

Thanks, Mahesh. I will therefore remove the edits where I made

strandedness

a channel, and request a review

We have been talking about your PR a lot yesterday actually

Thanks Maxime. I'm following up on Simon's comment (in the PR) and opening a different PR that excludes bumping

sentieon/rsemcalculateexpression

. This can isolate the issue while at the same time unblocking the remaining sentieon modules from being bumped.

you can check out the discussion in #C043UU89KKQ I started one, and then 3 threads for 3 different topics, one of them being the strandeness

Nice! Thanks Maxime