improved the use of samplesheet and fixed input so...
# request-review
p
improved the use of samplesheet and fixed input source for
rnasplice
github.com/nf-core/rnasplice/pull/259
approved with comments 1
merged 1
Hi @Jonas S, did you leave some comments? I cannot see them on Github šŸ™‚
j
Sorry I confused your PR with another šŸ™‚
Just had a comment on the comments that contain unnecessary information from your Claude conversation. Maybe worth paying attention in future PRs
šŸ‘ 1
p
Sorry I still cannot see the comment and the review
j
I’m so sorry, I hit submit review twice and tabbed away, but somehow github did not register the click. Now it should work!
p
Thanks for the comments! Fixed and replied in the PR šŸ™‚
āœļø 1
j
One small design question, then its āœ… from my side šŸ‘
p
Thanks! Just replied :)
@Jonas S Can you please have a look when you have time? Thanks!
approved with comments 1
thanks for the comments! In the next pr I'm gonna remove the samplesheet parsing from inside the main pipeline to have it just once.
j
Great šŸ™Œ