https://nf-co.re logo
Join Slack
Powered by
All the modules CI are failing at the moment. Do w...
# team-maintainers
s
All the modules CI are failing at the moment. Do we need to use this detect-nf-test-changes anymore? Can nf-test not do this natively? Could we force the code to merge in master to the PR before running, so it doesn't run all the changes that have been merged since the branch was last updated?
party this 1
a
It looks like it's needed for GPU checking only - I wonder if we can get rid of it?
My plan: ā€¢ I will fix detect-nf-test-changes now, it's a packaging issue so should be quick(ish) ā€¢ In parallel, can someone see if we can deprecate it in modules?
Nice, I see @Jonas S had the same idea: github.com/nf-core/modules/pull/12897
šŸ«” 1
Excuse the AI slop review but Codex found some issues. I find this stuff really hard to parse with my human brain šŸ˜µā€šŸ’«
j
Same here! šŸ˜„
Could you have a look again? šŸ™‚
a
Looks good to my human eyes, just getting the machine to double check
party chatgpt 1
Aaghhh I'd like another infra person to check this but Matthias is on leave. Does anyone feel equipped to review GHA?
p
I'm core team on call this week
Whaddya' need?
a
Could you review this PR?
p
It's already queued to merge?
a
Well shit Oh bother
šŸ˜† 1
p
shared a GIF
a
Still, a fresh pair of eyes couldn't hurt
p
oops, got distracted by the postman and it's merged now
As it's modules, I think it's probably ok to test in production (especially as it's fixing a hard break right now)
I'm assuming you've already done due diligence with an LLM. Eyeballing it, it looks sensible
mild panic intensifies 1
a
basically what I didšŸ¤ž it looks good
šŸ‘šŸ» 1
j
Aaghhh Iā€™d like another infra person to check this but Matthias is on leave. Does anyone feel equipped to review GHA?
Sorry @Adam Talbot I did not see your comment before queueing the PR
m
What happened? What did I miss?
j
end of the world
šŸ˜… 1
2 Views
Open in Slack
PreviousNext
Powered by