Ok I'm done with 9 out of the 10 modules included ...
# genephylomodeler
l
Ok I'm done with 9 out of the 10 modules included in GPM, just missing RELAX as I've never used it so I'm not sure how to format the foreground vs reference tags (so I can build a test for the module) Also idk if other modules should be made (PRIME etc)? I guess one for DRHIP would be good at least?
though I'm not sure if DRHIP would work with the directory structure of results in nf-core - the results are indeed in folders with the name of the method but these are lowercase and not uppercase, don't know how strictly DRHIP enforces the name match
d
ill make any changes you need in drhip, just let me know.
feel free to ping
l
Thanks, I did take a look at the modules in CAPHEINE but my problem is related to the format of
Copy code
val(foreground_tag)
val(reference_tag)
Without them I can't make a test for the module. Are they tree node numbers? Leaf/sequence names? Are they passed as a list? Comma-separated or some other separator?
d
oh i see, misunderstood initially. some things to help, see: github.com/veg/CAPHEINE/…/labeltree where hyphy adds these little annotation on nodes in newick and help.datamonkey.org/methods/relax.html .. so you can use regex or list to label nodes 'foreground' vs 'background' and then the labels are what you pass to relax.
so relax test will want an already labeled tree, but actually using relax in a wf youll want to let ppl label their trees also
l
Ah so there should probably be a module for labeltree upstream of relax then, right?
👍 1
regarding upstream/downstream logic for the pipeline itself as well (not gonna touch it for now but just reflecting on it), should we also run the fragments obtained from GARD through the other methods ie let's say user wants to do GARD BUSTED and FUBAR on geneX, all 3 of those methods are run but GARD identifies one breakpoint, it would make sense to run BUSTED and FUBAR again on both fragments, wouldn't it?
d
if gard finds breakpoints, i would run only on the breakpoint trees for the other methods.