https://nf-co.re logo
Join Slack
Powered by
While we're at it, I have a question, I can see we...
# demultiplex
m
While we're at it, I have a question, I can see we have this module which seems to me like a waste of a process: https://github.com/nf-core/demultiplex/blob/master/modules/local/fastq_to_samplesheet/main.nf I recently replaced such a module in #C024915L4KB: https://github.com/nf-core/fetchngs/blob/25949b6fc2ade7fe26dbc5ae909b18ee170b4578/modules/local/sra_to_samplesheet/main.nf -> https://github.com/nf-core/fetchngs/blob/dev/subworkflows/local/channel_sra_create_csv/main.nf Is there really a need for such a process here, as far as I understand we are only creating a samplesheet, and do not need such a process for what can be achieved via pure groovy / channel manipulation
I am quite happy with how it turned out. @Matthias De Smet what do you think?
Failure on latest-everything seems unrelated, something with workflow output, I am investigating
m
Iā€™m kind of wondering if this should go in a plugin šŸ¤”
@Nicolas Vannieuwkerke has been doing some very cool (very reusable and configurable) work to make downstream samplesheets for our in house pipelines
you know you want it
šŸ˜‚ 1
m
yeah
one step at a time
but yeah, given what we have in sarek, fetchngs, here and other pipelines, I am sure we can whip something out
the main question is would that be useful enough to warrant a function in a plugin
m
one step at a time
who are you and what did you do to Maxime... šŸ¤”
šŸ¤£ 3
the main question is would that be useful enough to warrant a function in a plugin
I would suppose such a thing can be useful for any pipeline that works downstream of another one
m
@Rob Syme is what I am doing here a good idea?
chefs kiss 1
Thanks Anabella ā¤ļø. I have merged the PR in, thinking it was the other one I just created that was fixing some workflow outputs facepalm
Open in Slack
PreviousNext
Powered by