https://nf-co.re logo
Join Slack
Powered by
When running `nf-core modules lint --local` I am g...
# tools
a
When running 
nf-core modules lint --local
I am getting this error:
Copy code
/nf_core/modules/lint/__init__.py:247 in <listcomp>                                                                                                                                                                                                                       │
│   246 │   │   │   self.passed += [LintResult(mod, *m) for m in mod.passed]                                                                                                    │
│ ❱ 247 │   │   │   warned = [LintResult(mod, *m) for m in (mod.warned + mod.failed)]                                                                                           │
│   248 │   │   │   if not self.fail_warned:

TypeError: LintResult.__init__() missing 1 required positional argument: 'file_path'
👀 1
I think the culprit is this line: github.com/nf-core/tools/…/main_nf.py#…
Copy code
if not emit_regex:
    self.failed.append(("missing_emit", f"Missing emit statement: {line.strip()}", self.main_nf))
It only appends a 3-tuple, not a 4-tuple. I guess we have never hit this in 5 years somehow! The line that caused it was someone splitting an output tuple over two rows (so that one logical line didn’t have its own 
emit
) I think this failure of local linting was actually silently swallowed when running 
nf-core pipelines lint
too? EDIT: Actually it looks like a prior critical failure in applying a patch during the nf-core module linting causes all module lint output to be suppressed from 
nf-core pipelines lint
Issue I’d consider this a fairly pressing concern. I would suspect it also affects 
subworkflows
under 
pipelines lint
but I have not checked yet.
j
2 Views
Open in Slack
PreviousNext
Powered by