<#2193 Refresh the custom/orfcollapse fixture for ...
# test-data
g
#2193 Refresh the custom/orfcollapse fixture for the positional orf_class vocabulary Pull request opened by FelixKrueger The
custom/orfcollapse
fixture still carries
orf_class = smORF
, which nf-core/riboseq's ORF catalogue no longer produces — a short ORF now keeps its positional class (
uORF
,
dORF
,
canonical_cds
, …) and a separate
is_smorf
column carries the length flag. The catalogue also gained an
orf_type_native
column holding each caller's own ORF-type label. This updates
cohort.catalogue.tsv
to that schema, so the three small ORFs become `uORF`/`uORF`/`dORF` and both new columns are present. The BED12, ORF-to-gene map, peptide FASTA and cluster TSV are unchanged, and the module test still collapses the same two identical-peptide rows onto the same survivor. AI-assisted detail — keep or bin as you see fit Needed because
custom/orfcollapse
now aborts on an
orf_class
value it does not recognise, rather than silently omitting those rows from its per-class MultiQC table. With
smORF
gone from the module's vocabulary, the current fixture fails the guard. Row-level changes to `cohort.catalogue.tsv`: | orf_id | was | now | is_smorf | orf_type_native | | ------------ | ------------- | ------------- | -------- | --------------- | | orf_00000001 | smORF | uORF | 1 | 5'UTR | | orf_00000002 | smORF | uORF | 1 | uORF | | orf_00000003 | canonical_cds | canonical_cds | 0 | Annotated | | orf_00000004 | smORF | dORF | 1 | 3'UTR |
orf_00000001
and
orf_00000002
keep the same class on purpose. They are the identical-peptide pair the fixture exists to exercise, and orfcollapse prefers the more specific class when a peptide cluster spans several — so giving them different classes would change which row survives the fold and break the test's
orf_00000001
survivor assertions.
cohort.catalogue.mqc.tsv
is regenerated over the module's current class order. It is not consumed by any test, but leaving
smORF
in it would misinform the next reader. Verified by running the module template against the updated fixture: all thirteen assertions in `custom/orfcollapse`'s
main.nf.test
hold — 4 rows collapse to 3,
orf_00000002
folds into
orf_00000001
, the survivor unions both callers and both samples, the ORF-to-gene map remaps `g5`/`t5` onto the survivor, and the peptide FASTA keeps only the survivor. The survivor's
orf_type_native
becomes
5'UTR,uORF
, the union of the folded members' labels. The corresponding pipeline change is not yet open as a PR; this fixture update has to land first, since the module test cannot go green without it. nf-core/test-datasets
Review on #2193 Refresh the custom/orfcollapse fixture for the positional orf_class vocabulary Review approved by erikrikarddaniel on FelixKrueger's pull request 👍 nf-core/test-datasets