Would anyone be available for a review of this med...
# createtaxdb
j
Would anyone be available for a review of this medium sized PR? Slightly more taxing but it's quite important - as it fixes those stupid 'ConcurrentModificationErrors'!!!! https://github.com/nf-core/createtaxdb/pull/202/changes 1. It switches groupTuple to the new groupBy at the suggestion of @Ben Sherman (<3) to fix the error 2. Refactors the building steps into a dedicated subworkflow, which I wanted to do but also needed to do to get the nf-tests to trigger properly on GHA for some reason
😲 1
m
😱 glad you found a fix although it still seems mysterious...
j
Well Ben and Claude couldn't work it out so who knows... But if the fix works it works 👀