I can't make dev hours this morning sorry, but I w...
# taxprofiler
j
I can't make dev hours this morning sorry, but I worked with Lili fixing a few things yesterday so we should be close to a release :D
🙌 2
l
@Sofia Stamouli Will you join the dev meeting this morning?
s
I will join in 15 minutes.
👍 1
l
@James Fellows Yates Can I merge your PR Fix nanopore fasta input being incorrectly channeled? Once it’s merged, we can merge the PR that adds the Nanopore FASTA entry to the test samplesheet.csv
j
Yes, sure!
👍 1
How close are are we with bouncy basenji now so you think?
Should we patch release with the fix? Or just include it in nouncy? Directly and release that
As in 1.1.9 then 1.2, or directly 1.2
l
Just merge the update_modules PR, then merge your PR, and finally merge the PR updating the samplesheet. We’ll be ready to go
I would say very close
I need someone review the update_modules PR I have updated all modules and subworkflows
j
Ok, let's go straight to 1.2 then
@Sofia Stamouli do you think you could review the PR above?
s
Yes!
❤️ 1
l
I guess I also need to merge dev into bouncy-basenji, right?
j
Yes
l
I will do that now.
j
To make sure my fix doesn't break anything in BB Then B-B back into dev to make the release
PR Dev to master
l
Very clear instructions. I will pay attention to that
s
(joining now @Lili Andersson-Li)
👍 1