https://nf-co.re logo
Join Slack
Powered by
Does anyone know why `container "nf-core/modules/w...
# help
l
Does anyone know why 
container "nf-core/modules/wittyer:4c55c27c711b558f"
throw 
Unable to connect to container URL
?
m
Try without the "nf-core/modules"
l
Thanks !!
This did make nf-core modules lint pass but now the test doesn't pass anymore. Do you know why nf-core linting throw an error but not docker ?
m
do you have a PR link?
l
Should I got back to 
nf-core/modules/wittyer
?
m
yes, that seems to be the actual container name on quay.io...
there is also a 
nf-core/wittyer
module but that is older than the one with 
/modules/
. is there a dockerfile included with this module?
l
container "nf-core/modules/wittyer:4c55c27c711b558f"
does work for nf-test but fail with nf-core modules lint 
wittyer     │ modules/nf-core/wittyer/main.nf │ container_links: Unable to connect to container URL
Yes there is a docker file
By looking around, WITTYER is the only module in nf-core with 
nf-core/modules/module_name
adress for the container. All the other are as 
nf-core/module_name
container "nf-core/wittyer:4c55c27c711b558f"
works for lint but not for nf-test. Should we move the image to nf-core instead of nf-core/modules ?
m
that's what i am trying now 🙂
l
The issue is here in the nf-core modules/lint/main_nf.py
Copy code
# Guess if container name is simple one (e.g. nfcore/ubuntu:20.04)
            # If so, add <http://quay.io|quay.io> as default container prefix
            if line.count("/") == 1 and line.count(":") == 1:
                line = "/".join([registry, line]).replace("//", "/")
            url = urlparse(line.split("'")[0])
It doesn't take into account if it's more than one 
/
It can simply be fixed with 
container "<https://quay.io/nf-core/modules/wittyer:4c55c27c711b558f>"
Can I help in any way to move the container ?
m
nope, just takes time sorry
l
No worry, I was just wondering how it works 😉
m
https://nf-co.re/docs/checklists/community_governance/core_team#making-custom-docker-containers-for-modules (but i need to do it in a codespace to make sure i get the right platform build)
l
Thanks for the doc !
m
l
Thanks !
Open in Slack
PreviousNext
Powered by