I just noticed <that MultiQC now has a module for ...
# multiqc
m
I just noticed that MultiQC now has a module for UMI Collapse! Great news, I wanted to write one for months and never got around to actually do it, so very happy - particularly since the code is much cleaner than what I would have managed to come up with. 😄 However, since it was merged so quickly, I did not have the chance to point one little, but possibly important issue out: The search pattern is now defined as
Copy code
umicollapse:       
fn: "*_UMICollapse.log"       
num_lines: 100      
contents: "UMI collapsing finished in"
Mind though, that the
*_UMICollapse.log
name is only a convention of the nf-core module:
Copy code
UMICOLLAPSE_JAR=\$(dirname \$(which umicollapse))/../share/umicollapse-${VERSION}/umicollapse.jar
    java \\
        -Xmx${max_heap_size_mega}M \\
        -Xss${max_stack_size_mega}M \\
        -jar \$UMICOLLAPSE_JAR \\
        $mode \\
        -i ${input} \\
        -o ${prefix}.${extension} \\
        $args | tee ${prefix}_UMICollapse.log
since the tool itself is not outputting any log file. Hence I was wondering if that search pattern should be applied or if it should be file contents only?
❤️ 1
p
Good catch 👍🏻
You're right, it should be file contents only
Would you mind putting in an issue / PR about it please? 🙏🏻
💯 1
m
Done, but I am unsure if the unique reads in FastQ mode are actually the dedup input reads of the BAM mode. Maybe @Alex Peltzer or @Charlotte Capitanchik knows more? https://github.com/MultiQC/MultiQC/pull/2827
💯 1
a
Dont know myself either, sorry @Matthias Zepper