Have you tried with Nextflow edge?
# pipeline-maintainers
m
Have you tried with Nextflow edge?
p
This is running with a fresh build of Nextflow, so it's even edgier than edge
m
😔
Ok, mention this to Ben then
Because according to him it's probably fixed in edge
p
The error that I get for rnavar with
--help
is different to the one you posted about in the ambassadors channel: https://github.com/nf-core/strict-syntax-health/blob/main/lint_results/prints-help-results/rnavar_help.txt
m
Interesting
Ok, so it might be another error then
I know what to play with on Monday
p
It's not just this pipeline, there are a bunch with the same error. So I suspect it's something that needs fixing in the template
Putting in a PR now
m
Thanks, I'll have a look at putting this in TEMPLATE
p
Sorry didn't see your message and already did it homer disappear
https://github.com/nf-core/tools/pull/3986 but then closed as I realised it wasn't a local subworkflow in template, so moved to #CJRH30T6V for the subworkflow
m
Yeah I'm trying to transfer these subworkflows to plugins
👍🏻 1
b
I think what's happening here is that the implicit type casting of CLI params is disabled with strict syntax (see 25.10 deprecations) This is because the new
params
block will take care of this for you and we don't want the legacy type detection to interfere with that So my thinking was that existing pipelines should treat every param as a string, at least until migrating to the new
params
block In this case you should be able to fix it
<http://params.help|params.help> as Boolean
And it might be worth documenting this guidance somewhere
p
Ok so my fix works because it's checking that the string version of the param isn't
true
If I typecast it as a Bool it'll always return true though, both if it's a flag and if it's a custom string? So not sure that'll work here
We're trying to discern
--help
from
--help foo
f
So what do I need to do if my help is not being printed? Change params.help to Boolean?
p
If you're using the centralised subworkflow, just wait for the above to be merged and then update.
👍 1
If it's local, then take a look at the PRs above and replicate the fix
b
You're right, looks like you have to just compare to "true" / "false" Here is the legacy type detection code for what it's worth: https://github.com/nextflow-io/nextflow/blob/295f17307c2d0effc3e7bd93923550a3cb47b[…]14c/modules/nextflow/src/main/groovy/nextflow/cli/CmdRun.groovy
p
ok cool, so then I think my PRs are the right way to do it / the right fix.. Right? 😅
🤞 1