https://nf-co.re logo
Join Slack
Powered by
How do we handle stuff like this: Warning: `subwor...
# pipeline-maintainers
f
How do we handle stuff like this: Warning: `subworkflows/local/utils_nfcore_bamtofastq_pipeline/main.nf315`: Parameter was not used -- prefix with 
_
to suppress warning
Copy code
monochrome_logs // boolean: Do not use coloured log outputs
    ^^^^^^^^^^^^^^^
Warning: `subworkflows/local/utils_nfcore_bamtofastq_pipeline/main.nf345`: Parameter was not used -- prefix with 
_
to suppress warning
Copy code
input //  string: Path to input samplesheet
Should I just add the 
_
?
m
Have you check what I have done in rnavar?
f
I am still confused as to how I need to use it
j
I am also getting the 
monochrome_logs
warning, what have you done in #C01NHS4CC91 @Maxime Garcia?
m
Err. Give me 5 min to get my computer
so I removed this line, as it's indeed not used in this subworkflows (weirdly, as we should have colors or monochrome on the logo)
and of course remove that one too
for input
And basically what I did in https://github.com/nf-core/rnavar/blob/dev/subworkflows/local/utils_nfcore_rnavar_pipeline/main.nf is to just remove all calls to the utils subworkflows coming from the modules repo, and just use the local utils subworkflows and functions from #C08TKFDUNHG
plan is to continue to strip the functionality from modules and TEMPLATE to plugin
So it's much easier to update
j
🙌🏻 thanks @Maxime Garcia
m
Planning some more thorough tests, but so far all seems good
f
I will open a PR to bamtofastq which does exactly these changes so then we can provide this to others as reference
🙏 1
m
I think updating the TEMPLATE would go a long way as well
👍 1
f
Open in Slack
PreviousNext
Powered by