I am a little lost on the strict syntax that I att...
# pipeline-maintainers
d
I am a little lost on the strict syntax that I attempt to follow in https://github.com/nf-core/ampliseq/pull/942. I can fix all errors or warnings (except nf-core modules & subworkflows). But now linting fails as in https://github.com/nf-core/ampliseq/pull/942#issuecomment-3778471460. So either I satisfy nextflow linting or nf-core linting, but not both? How do I solve this sustainably? I have seen https://github.com/nf-core/strict-syntax-health?tab=readme-ov-file#running-locally, that helps locally, but not for the PR?
✅ 1
j
Is there a. Update for that sub workflow?
@Maxime Garcia will know the answer anyway
😆 1
d
Is there a. Update for that sub workflow?
Maybe, thats a problem for later. The main problem is that nextflow lint / nf-core linting issue with nf-test.config & utils_nfschema_plugin thats blocking the way forward 😉
j
I mea t more that I thought
utils_nfschema_plugin
sub workflow is from nf-core, maybe the issue is fixed there and if you update it's solved. Regardless, you can't get full strict syntax compatibility anyway I believe, at least based on @Phil Ewels's syntax status page thing
p
I fixed the subworkflow already: https://github.com/nf-core/modules/pull/9680
nextflow lint [..] issue with nf-test.config
This just needs to be excluded. That's already merged to
master
in Nextflow but not released yet. But you can exclude it manually via the CLI as shown in James' screenshot
But because I already merged the fix to the subworkflow, I think you just need to run
nf-core subworkflows update utils_nfschema_plugin
and it'll pull in the same fix, but mark the updated subworkflow in
modules.json
Then
nf-core lint
won't complain
m
Not fully ready for inclusion in template but soon we can remove all utils subworkflows
But I always recommend to follow TEMPLATE
Even if I try to deviate from it as soon I can, but that's just me being french
d
Thanks a lot for your explanations! All good now.
p
Curious if this works - shout if it doesn't :)
d
Yes,
nf-core subworkflows update utils_nfschema_plugin
fixed that linting issue. And
NXF_VER=25.12.0-edge NXF_SYNTAX_PARSER=v2 nextflow run d4straub/ampliseq -r strict-syntax-nf25.10.2 --help
works.