Hi <@U04UWPBRAFP> - wondering if you can help me o...
# scdownstream
p
Hi @Nico Trummer - wondering if you can help me on this PR - the
SCDS
module tests are failing because it can't find this test data: https://raw.githubusercontent.com/nf-core/test-datasets/scdownstream/samples/SAMN14430801_custom_emptydrops_filter_matrix_sce.rds It looks like you've been working on the #C02L5UB4Y9G repo on this branch. The readme still says that there's a
./samples
directory but it's not there any more. Any suggestions on how we can fix these tests please? 🙏🏻 https://github.com/ewels/nf-core-modules/blob/1e0259db8e0a2b2c5bd99f83cc2ecf8583a85020/modules/nf-core/scds/tests/main.nf.test#L16
n
Ah yes I did not remember there are references to the pipeline test data from the modules repo - in the meantime, there should also sufficient test data in the Test-Datasets repo, I will look into details tomorrow
p
n
Sorry I was not very clear with what I meant - in the meantime, there should probably also be fitting data on the
modules
branch of the
test-datasets
repo, so that we can get rid of the dependency towards the pipeline test data I will check tomorrow
👍🏻 1
So here you can find relevant files I would recommend the
SRR28679757_filtered_matrix.sce.rds
, it is closest to the previous test file
Claude keeps telling me that the tests are failing because these files don't have the "counts" assay. Does that make any sense to you?
n
Hmm it might be the best to make the assay selectable via an additional module input, as the reliance on a specific one is not optimal I can add this, but I would do it after work today (I finish at 5) - I can't do too big side quests while working😅
But maybe you can also try claude if that's faster