Lastly, a reminder to everyone: Please do not com...
# seqinspector
m
Lastly, a reminder to everyone: Please do not commit large files or result folders of pipeline test runs to git. Even if you delete them with a later commit, they will be lingering around in the history as heavy baggage for everyone ๐Ÿ‘œ๐ŸŽ’.
๐Ÿ‘ 1
a
Could squashed merged be a solution to prevent this in the future? I mean if such files are committed and then deleted in another commit, it can be quite hard to see in a review, especially if the commits have generic names and if there are many commits. If the whole PR is squashed in one commit, this prevents this from happening, since in the case the diff you see in review is the content of the merge commit, no?
m
Possibly. I do recommend squash commit from PRs to dev anyway
m
I am definitively open to a squash commit policy (also because we noticed some unclear commit messages in the process as well), but that is ultimately for the maintainer group to decide. Until then, I have proposed tightened pre-commit hooks in the pipeline template: https://nfcore.slack.com/archives/C04QR0T3G3H/p1765382786144209
๐Ÿ‘ 1
m
I am making the executive decision then, on behalf of @Franziska Bonath to use squash commits from now on on this pipeline
extreme teamwork 2
s
You can set squash commits as required in the git settings right?
f
uuuuuhm, not everyone knows how to do this (like me)
m
No worries, it's automated, nothing will change for you
f
I see
m
we have been doing this in #CGFUX04HZ for ages thanks to @Ken Brewer for pushing for it
cowboyhat tip 1
f
btw, no decisions need to be done โ€œon my behalfโ€, I am not the one who needs to approve anything.
m
You're the boss, boss
f
we are a community
๐ŸŽ‰ 1
m
We can briefly discuss this and have a formal vote in tomorrow's meeting? I think that would indeed be more in the community spirit.
๐Ÿ‘ 1
party this 1
s
I think all pipelines should mandate squashing when they merge to dev
party this 1