Small but quite urgent PR: <https://github.com/nf-...
# ampliseq
d
Small but quite urgent PR: https://github.com/nf-core/ampliseq/pull/943. Would be great with a quick release since this affects a lot of reference databases.
✅ 1
d
How quick? I have found a bug in multiple region analysis and wanted to fix that (on it but not sure how long it takes with my fragmented time for coding)
d
A few days maybe, mid next week? I can do the release with my update if that helps. Would be good to get both out of course.
d
Ok, I'll see if I can finish the fix today&tomorrow, otherwise we do it without it.
👍 1
Ok, bug fix PR seems fine to me, review pending.
✅ 1
d
Fantastic! I'll have a look right away
d
You could make a release anytime, I think it would be 2.16.1 (and not 2.17.0) since its all bug fixes?
d
Absolutely. I'll do it tonight. Going for a run now
👍 1
Singularity tests failed for the dev -> master PR. Timeouts for the image download. How do you normally proceed? For "my" repos I think I would merge anyway.
d
I usually restart the failed tests, just to be extra careful. Usually they pass in the second run if it was indeed just a temporary issue.
👍 1
d
I tried to accept your date suggestions for the change log but it doesn't work. I get "Could not apply suggestion. Refresh and try again.". This never happened to me before. (And then I realised you had 2016 in the date instead of 2026 so I made my own suggestion with the correct year and that doesn't work either...)
d
I pressed the button and it miraculously worked 😄 If you want to you can skip the tests and merge, I usually let the pass though.
d
I see. I just saw it was updated. I'm not allowed to skip -- one probably needs to be owner -- so if you merge we'll save some electrons.
Now I suddenly could merge, so forget ☝️
🎉 1
Release done, waiting for your approval of the 2.17.0dev bump -- if I haven't forgotten anything!
(I don't release so often, so the likelihood that I forgot something is non-negligible! 😬)
d
Thanks! Looks al good 😉
👍 1