So looking at <@U020B09EJSZ> functions in <https:/...
# sarek_dev
m
So looking at @Pieter Moris functions in https://github.com/ITMmalaria/plasmovar/blob/dev/subworkflows/local/utils_nfcore_plasmovar_pipeline/main.nf, reminded me another forgotten plan. Basically I wanted to pull in the functions from sarek https://github.com/nf-core/sarek/blob/dev/workflows/sarek/main.nf#L643-L716 into #C08TKFDUNHG as I believe these are the king of things that we can share in between pipelines quite easily and I do believe a plugin would be a good idea for that. Main question now is do we want a dedicated plugin for these, as I do believe that these functions from Pieter would be a good addition, and something nice to have in sarek, and other similar pipelines, or do we want to pile in #C08TKFDUNHG. cc @Matthias De Smet @Nicolas Vannieuwkerke @Rike Hanssen
deploy parrot 2
m
yass
There’s some stuff that should go to
nf-schema
IMO, but all the fastq things would be really nice
m
ok, so what should go where? do we need a new plugin? like
nf-fastq-validation
?
m
Not sure I agree with the readgroup handling though, but thats a matter of opinion. I tend to follow the Illumina defaults
like
nf-fastq-validation
?
Not sure if “validation” is the right word here 🤔
n
I'd prefer file specific functions to be in a plugin called
nf-<file_type>
so
nf-fastq
for example in this case
m
nf-core-fastqtils
?
n
All functions that don't have an obvious place could go in #C08TKFDUNHG
👍 1
Although that all file processing should a process IMO but that's another discussion
m
👀 1
Although that all file processing should a process IMO but that’s another discussion
This is not file processing per-se; more like a range query to get the first line and parse it, so no heavy transfers for the head job
party this 1
p
I'll have a more indepth look later, because I was trying to follow the illumina defaults too 😅
n
Not a #C0749PAEU9F, no worries 😉 sounds good in this case indeed
m
@Pieter Moris, we mimic the RG field extraction from
bcl-convert
fwiw, if you use
bcl-convert
you get almost all of the rg processing for free
p
Oh that could be useful..
m
You can add custom fields to the samplesheet for extra RG fields and you get a nicely formatted tsv with RG fields for each sample
👍 1
p
Btw: I remember I had to make a bunch of exceptions for SRA files because their headers are sometimes different. Just a thing to keep in mind here too.
m
yeah, you can do bclconvert if you do the sequencing, but if you get fastq files from somewhere else...
m
yeah, I know, that’s why the fastq functions mimic the bcl-convert behaviour, so there’s less mismatches
🙏 1