https://nf-co.re logo
Join Slack
Powered by
<@UE6D8290F> <@UQZG2UCF3>, I really appreciate con...
# request-review
a
@Maxime Garcia @mashehu, I really appreciate confirmation that @Jeremy Muhlich has resolved your review questions on https://github.com/nf-core/mcmicro/pull/120. Our annual reporting for the grant funding this work is due this week, and I would love to make sure we are able to report this as merged! Thank you so much!
👀 1
m
Is there a corresponding working megatest?
a
@Maxime Garcia we had a successful full test last week here: https://github.com/nf-core/mcmicro/actions/runs/27700805258/job/81936355759 Can I get added to the nf-core AWSmegatests workspace to see the run logs
FYI @Jeremy Muhlich linting error fixed in https://github.com/nf-core/mcmicro/pull/156... feel free to merge or implement a single line change in dev
j
@Adam Taylor thanks for fixing those. I swear all tests (except 
pipelines download
) were already passing after Alex's last PR a week or two ago.
@mashehu The second "linting" failure is actually a failure of 
nf-core pipelines download
due to strict syntax issues. We're not ready for strict syntax (it's coming in the next template merge!) so can we edit that GHA workflow to use nextflow 25.10 for now?
👍🏻 1
m
yes, sounds good
j
@Maxime Garcia OK, all tests passing now. Do we need to get the megatest going for this or can that be done in a subsequent update after release?
(sorry I keep @-ing Matthias by accident instead of @Maxime Garcia here 😅 )
a
@Jeremy Muhlich I've launched a new megatest and will report the result
m
it would be preferable if possible
a
j
thank you all
2 Views
Open in Slack
PreviousNext
Powered by