https://nf-co.re logo
Join Slack
Powered by
Topic versions for prodigal: <https://github.com/n...
# request-review
d
āœ… 1
Thanks @mashehu for the review. Tests for another module are failing. I've pressed "Merge when ready", but will it wait forever until the other tests pass?
šŸ‘šŸ» 1
Is there anything I can do about that?
m
merge the master branch in
d
I don't think I can. I can press "Merge when ready", but then it tells me nothing will happen until all prerequisites are met. Can you force merge?
m
will have a look
d
Could it be that I had some old updates that I included by mistake and triggered tests that fail?
m
ah, the failing modules are downstream modules of this module.
d
But there were only three files updated in the PR
Right, so I'd better try to update them too?
m
e.g. dastool has 
tag "prodigal"
in the main.nfn.test
if it is not too difficult
d
Will try
m
give it one try and if that fails, I can force merge it
šŸ‘ 1
d
I just reran the dastool/dastool test on the command line, without problem or updated snapshot:
Copy code
$ nf-test test --profile +singularity modules/nf-core/dastool/dastool/tests/main.nf.test --update-snapshot

šŸš€ nf-test 0.9.5
<https://www.nf-test.com>
Please cite: <https://doi.org/10.1093/gigascience/giaf130>
(c) 2021 - 2026 Lukas Forer and Sebastian Schoenherr

Load .nf-test/plugins/nft-anndata/0.4.1/nft-anndata-0.4.1.jar
Load .nf-test/plugins/nft-bam/0.6.1/nft-bam-0.6.1.jar
Load .nf-test/plugins/nft-csv/0.1.0/nft-csv-0.1.0.jar
Load .nf-test/plugins/nft-compress/0.1.0/nft-compress-0.1.0.jar
Load .nf-test/plugins/nft-fastq/0.1.0/nft-fastq-0.1.0.jar
Load .nf-test/plugins/nft-utils/0.0.9/nft-utils-0.0.9.jar
Load .nf-test/plugins/nft-vcf/1.0.7/nft-vcf-1.0.7.jar
Warning: every snapshot that fails during this test run is re-recorded.

Test Process DASTOOL_DASTOOL

  Test [ae30b6db] 'dastool dastool - bacteroides fragilis - noproteins' PASSED (766.505s)
  Test [6f9acb1b] 'dastool dastool - bacteroides fragilis - proteins' PASSED (59.841s)
  Test [cf46c0d0] 'dastool dastool - bacteroides fragilis - stub' PASSED (17.144s)


SUCCESS: Executed 3 tests in 843.506s
quick look 1
m
which nextflow version were you using?
d
26.04.3 build 12259
m
we use 25.10.2 in the CI, maybe that makes the difference? anyway will force merge now, because the test failures should be unrelated
šŸ‘ 1
d
It fails with 25.10.2 on my command line too
2 Views
Open in Slack
PreviousNext
Powered by