Hi <@U04UWPBRAFP>, I submitted a PR a while back f...
# modules
a
Hi @Nico Trummer, I submitted a PR a while back for a very minor change to cellbender/removebackground module, and requested a review, but nothing seems to have happened. Is there something I should do to push this along, or is it just not going to happen? https://nfcore.slack.com/archives/CQY2U5QU9/p1780512999310209
p
Keep nudging people and requesting review on #CQY2U5QU9 (as you are doing), this is the correct approach.
Offering to swap a review with someone else who is asking is often a good approach (that's the idea of the channel really)
eg. post on someone else's message in that channel with a link to your slack message and offer to swap
a
Thanks, @Phil Ewels, I just worry that I'm such an nf-core novice that it would be irresponsible of me to review someone else's PR. I guess I'll see if there is something I actually know about.
n
Hey, from the PR I see that you marked it as ready for review, but you did not explicitly request my review. I am not notified in this case (even when I am listed as the maintainer), so I missed the PR. You can use the feature in the top right of the PR to request my review, I usually should not miss this. If I do, feel free to message on slack
a
Sorry, @Nico Trummer, I didn't know the protocol. Should I also request your review on the related test data PR?
p
@Alec Wysoker I'd recommend doing the review, it's a great way to become more experienced - you get exposed to more code and learn! You can mention in your review that you are novice and would like a second review, that's fine.
👍 2
Requesting review is great, though note @Nico Trummer is probably fairly rare in listening to GitHub notifications. All my GitHub emails go straight to trash 😆 So generally speaking it's good not to rely on that or ever assume that people have seen your activity.
lmao cowboy 1