https://nf-co.re logo
Join Slack
Powered by
Thanks <@UPC8CHDKQ> for making progress on the sav...
# sarek_dev
m
Thanks @Rike Hanssen for making progress on the save_bam PR
r
I think I found a redundancy in mine. Will double check before merging. Thanks for the approval
🙏 1
Pushed an unconvetional change because mac and spark are not friends. No worries about it, no need to review, just abusing the CI to test a theory
m
all good for me
Check my PRs too, that's all I ask
r
let me ping you when I need another review. just abusing the CI at the moment so some things are still in flight
tests are finally all passing. Will do a last self review tomorrow and then pass it back to one of you
m
I'll check tomorrow then, I'm out already
r
yep same + brain fried so no more reviewing my own code today
ok I am finally happy and the tests seem to have finally run through. If you'd like to take a look
m
On it
I approve again
r
I have paid my taxes as well and approved yours
m
YEAAAH
let's go merge all
r
ahhh why are the tests rerunning
m
there was a merge conflict on 2203 anyway
When do we want to release?
tomorrow?
r
do you know someone you can strong arm into reviewing this beast in the morning?
m
oh right, we need reviewers
😆 1
r
pesky rules shakefist
m
Jon did one
shall we review ourselves?
r
m
LOOOL
My issue here is that the 3 of us are deeply involved here
r
yeah it's been a effort. which is good
m
ok, let's ask external then
r
I'll trigger the full size tests now via the action so we have something to investigate or hopefully not in the morning
🙏 1
2 Views
Open in Slack
PreviousNext
Powered by