https://nf-co.re logo
Join Slack
Powered by
Debloat release PR: <https://github.com/nf-core/pr...
# request-review
e
Debloat release PR: https://github.com/nf-core/proteinfamilies/pull/173 In a nutshell -> removing 133 files from the next meaningful release PR
👀 1
m
That's a release PR?
I'm a bit confused to be honest
Are you splitting the release PR in 2?
e
I dont want people that actually must review something, also have to scroll through just module updates, so I fired a PR with this to debloat future reviews
think of it as -133 files from the next actual release PR 😛
m
Understandable, only issue I see here is that the main branch is temporarily unstable
"unstable"
But I really appreciate that idea
I think I prefer only merging things that are ready to release on main/master, but I don't know if it's a personal preference, a guideline, or a rule
Shall we argue about it during the next maintainers meeting?
➕ 1
e
There is not another PR planned that will come out that soon at least. This is a minor release (and not a patch release) because, it kinda fits these two points in the documentation:
Copy code
Expanding documentation or adding new examples without altering core functionality. -> I added documentation-like comments throughout
A template update to a newer nf-core template. -> not actual template udpate, but nf-schema got a version update along with multiqc, and now completely removed legacy ch_versions (all from topics)
it's in the guidelines of 
keep PRs less than 100 files as much as possible
m
just to be clear: this will be a released after merging?https://github.com/nf-core/proteinfamilies/pull/173
e
Ofc
👍🏻 1
Open in Slack
PreviousNext
Powered by