anyone avail for this? thanks!
# request-review
p
anyone avail for this? thanks!
πŸ“ 1
s
Not for now, but could you add this module directly to multiqc, so that the custom processing is not necessary?
p
Yes, I can do that, but still working on what's the best way to include rMATS results in multiQC. At the moment, I've just added the summary table. Any suggestion is very welcomed!
s
I have absolutely no idea what the tool outputs πŸ˜‰ @Uri David Akavia I think was working on rmats modules, maybe he has some insight
p
Ok, so for the time beings, I won't include it in the report for rnasplice. I think it's better finishing the refactor which is being a lot of work and it's still not completed.
u
I glanced at the PR. This PR has refactoring, which is extensive, and the addition of RMATS. I would think it should be two separate PRs - if you want, I can review the RMATS related modules and files. However, if you're going to take it out of the PR for now, the question becomes moot
Would you like me to review, or are you rewriting the PR?
p
Ok, let me split into 2 PRs, so the most urgent is to fix the output dirs
Can you please have a look? I've simplified the pr to fix the most urgent things. Thanks!
βœ… 1
Regarding RMATS, I am not sure that a module for multiQC would fit because the only meaningful output that you can get are contrasts-based summaries or logs so nothing sample-based. It looks to me that all modules are sample-centric instead...
s
yes, multiqc is generally sample based, that is true
you could always ask @Phil Ewels πŸ˜‰
p
I'll do thanks! And thanks for the review too! ☺️
p
some modules aren't sample based - eg. demultiplexing is lane-based
MultiQC doesn't care πŸ€·πŸ»β€β™‚οΈ
p
Great! Let me find some time to work on this module then. I'll have a look at demux to understand the best approach for RMATS. Thanks!
πŸ‘πŸ» 1
p
There's a new-ish skill in the repo that should help if you have an LLM at your disposal..