also, am I missing something or does viralrecon no...
# viralrecon
s
also, am I missing something or does viralrecon not do minimum depth masking of genomes?
j
s
That is horrendous
💯 1
j
shared a GIF
🙃 1
s
ffs
that's legit enough reason for me to put a big "DO NOT USE" over it I'm afraid
😢 1
j
Just make a config and patch the
-m <depth-of interest>
Copy code
process {
            withName: 'IVAR_CONSENSUS' {
                ext.args = '-t 0.75 -q 20 -m 10 -n N'
                ext.args2 = '--count-orphans --no-BAQ --max-depth 0 --min-BQ 0 -aa'
                ext.prefix = { "${meta.id}.consensus" }
                publishDir = [
                    [
                        path: { "${params.outdir}/variants/${variant_caller}/consensus/ivar" },
                        mode: params.publish_dir_mode,
                        pattern: "*.{fa,txt}",
                    ],
                    [
                        path: { "${params.outdir}/variants/${variant_caller}/consensus/ivar" },
                        mode: params.publish_dir_mode,
                        pattern: "*.mpileup",
                        enabled: params.save_mpileup
                    ]
                ]
            }
s
Oh the default is 10, that's not too bad
I'd prefer 20 but copable with
j
Haha
s
custom config is unfortunately a bit beyond the artic network users
not everyone ofc, but when we're going a recommendations for sequencing scary new virus we have to have a strong focus on usabillity
j
I get that.
s
Maybe this a sign for us @CJ Jossart @Lili Andersson-Li to think about fixing this issue: https://github.com/nf-core/viralrecon/issues/447 And expose the minimum depth through params
✅ 1
c
Yeah I can take a look at this and see what will need to be updated!
👍 1
l
@CJ Jossart Great! You are going to take care of this issue!