Could I get a look at a small version update to th...
# request-review
j
Could I get a look at a small version update to the
rundbcan
modules, and making an output directory optional in one of them: https://github.com/nf-core/modules/pull/11242
✅ 1
m
small?
j
Version bumps!
Technically small 😉
Same thing just 5 itme
m
yeah, I can see that now
I was mislead by the number of lines changed
j
My bad, should have been clearer
m
No worries
j
salute
m
Happy for the ✅, to be honest, I was half expecting some discussions about my usage of the meta map
j
I don't look too closely at meta maps in subworkflows tbh..
I can check again though if you want
But ntohing jumped out
Which bit exactly?
m
usage of a meta key that is not id or whatever
but I am deleting just after, so it's just in the subworkflow, so I'd say we're fine
j
Yeah exactly, that's a reasonable pattern?
🎉 1
m
WHY are so many tests FAILING???