I have a very big modules PR, I would like some ex...
# team-maintainers
i
I have a very big modules PR, I would like some expert opinions on it, since I must have missed something. Opinions from @Maxime Garcia, @Rike Hanssen, @Famke Bäuerle, and @Luisa Santus especially appreciated, since they have recently worked with the relevant modules. https://github.com/nf-core/modules/pull/11571
🙌 1
s
That is indeed a big PR that I don't have time to review now.
i
No worries, it's not urgent, I'd be happy if I can get the reviews by Wednesday afternoon, but nothing will happen if I don't
CI passing, if anyone is bored/committed feel free to have a look
f
i had a look 🙂
i
Addressed as much as I could, CI passing again. I feel like it's going somewhere, just not too quickly
@Famke Bäuerle can you have another look at some point? I've tweaked what I could, tests are okay
@Famke Bäuerle? I really want your approval on this, since you have worked a lot on these mdules lately
f
hey sorry been a bit swamped with teaching I will take another look 🙂
i
Great, thanks