Template merge fun times: <https://github.com/nf-c...
# request-reviewj
Jonathan Manning
05/05/2026, 4:26 PMTemplate merge fun times: https://github.com/nf-core/rnaseq/pull/1827
Will swap!
approved 1
d
Daniel Lundin
05/05/2026, 4:44 PMLooks good. I found just a spelling mistake -- probably in template code. Waiting for tests to pass before submitting the review.
This was my first 4.0.2 review and I haven't yet merged any into my pipelines, so I might have not understood everything. Thanks for the full description in the PR text.
If you can, please have a look at my test data PR: https://github.com/nf-core/test-datasets/pull/2035
👀 1
j
Jonathan Manning
05/05/2026, 4:47 PMCan you submit the review now? Then I can interrupt the currently running tests with any fixes 🙂
d
Daniel Lundin
05/05/2026, 4:47 PMDone
thankyou 1
j
Jonathan Manning
05/05/2026, 4:52 PMPR to fix template typos: https://github.com/nf-core/tools/pull/4263
Jonathan Manning
05/05/2026, 4:53 PM('focussed' is actually a valid variant, but sufficiently rare to be fixed)
d
Daniel Lundin
05/05/2026, 4:55 PMYou set it to
masterj
Jonathan Manning
05/05/2026, 4:58 PMGarr, that was silly
d
Daniel Lundin
05/05/2026, 4:58 PMHappens to me all the time; I always feel silly
Daniel Lundin
05/05/2026, 7:55 PMI closed my PR, and created a new: https://github.com/nf-core/test-datasets/pull/2036
2 Views