I would like to know your point of view on the mod...
# team-maintainers
l
I would like to know your point of view on the module naming and subtools for the following PR: https://github.com/nf-core/modules/pull/11514 Documentation of the tool : https://github.com/bigbio/sdrf-pipelines/blob/main/README.md TLDR: only one tool name
parse_sdrf
with many options
validate-sdrf|convert-{openms,maxquant,msstats,mhcquant}|split-sdrf|...
My first thought would be to name the modules
PARSESDRF_SUBTOOLS
like bcftools.
i
Since this is the only command, it's effectively the name of the tool, so the usual
TOOL_SUBTOOL
naming should be appropriate
j
@Rike Hanssen and I relatively recently add examples in the modules specs: https://nf-co.re/docs/specifications/components/modules/general#module-granularity Does that help?
l
This does confirm it should
PARSESDRF_SUBTOOLS
, thanks !
Question from Jonas: should it be
PARSESDRF_SUBTOOLS
or
SDRFPIPELINES_SUBTOOLS
? • sdrfpipelines is the name of the repository and the conda package • parsesdrf is the command line used • subtools the option after parsesdrf
i
Whoever named this must be a bioinformatician
🤣 3
💯 1
Not sure which makes more sense to a user, but my intuition says
PARSESDRF_SUBTOOL
(with
sdrfpipelines
in keywords just in case)
l
Last question, the different converter use the same inputs, do we create a global
PARSESDRF_CONVERT
and give a
val(format)
to avoid having to duplicate for 4 output type ?
i
If they behave identically except for the format I'd say yes