Do I need a formal approval from nf-core to merge ...
# nostupidquestions
u
Do I need a formal approval from nf-core to merge a PR, or if someone from nf-core reviewed it, I fixed all the issues, and the tests pass, I can just queue it for merging? I'm trying to balance bugging nf-core members and not wasting people's time. Thank you
m
as soon as you have a ✅ and no outstanding comments, you are good to go.
u
Sorry, very literal minded person here. Do you mean when they've pressed approved on Github (and the checkmark appeared), or when they say "looks good to me" (even if they haven't pressed approve)?
m
sorry for not being clearer before: yes, approved via the github review approval.
u
Thank you!
s
I've reviewed again and given you the ✅ . Uri David, please just keep hassling if you need things reviewed 😉