But got a bunch of errors - not sure which are me ...
# tools
j
But got a bunch of errors - not sure which are me yet vs the code, but definitely the one above is a bit concerning (prek couldn't be found with
lint
)
m
ah, it's because it is
uv tools install
. @Arthur already ran into this.
j
Btw for a migration guide: I have a very fucked up
/main.nf
so that one would be one to report. Basically if I accept 'current change' as is, I end up with a double
workflow NFCORE_CREATETAXDB
entry
m
yes, I saw that one... stupid git. not sure we could fix that by reshuffling things in the tempalte, because it is a strict syntax thing if i rmember correctly
j
yeah, that;s what I'm thinking too - that's why maybe updating the blog post (unless you put the migration guide) with a big fat warning about that one?
And the multiQC logic in
workflows/createtaxdb.nf
scares me too 😆
Also is this meant to be one line? 🤔
But otherwise once I fixed mistakes in the two things I made listed above, look all good so far: https://github.com/nf-core/createtaxdb/pull/189 Just the problem with installing nf-core tools for nf-core tools linting 🙂
m
fixed in https://github.com/nf-core/tools/pull/4238 I am waiting for more things to come in and then will push tomorrow a patch release out
👍 2
j
Wrong thread
😁 1