Got a couple of topic conversions if anyone has a ...
# request-review
j
👀 1
✅ 1
j
@Louis Le Nézet small reminder it's always best to leave just
comment
in a review rather than request changes unless there is something REALLY badly wrong and blocking
As otherwise e.g. even I approve the changes you requested on your behalf, and the original author can't merge until you give an accepting review (unless they disregard your review, which isn't super nice)
l
Ah sorry, I will do so in the future !
j
❤️
I've dismissed the review for you so @Jim Downie can merge 🙂
❤️ 1