(with apologies to <@U03DN4C1JQ5> for asking): how...
# team-maintainers
j
(with apologies to @Jonas S for asking): how insistent should we be that modules are added to nf-core/modules rather than as local modules? Seems like there's a bunch of useful things in here: https://github.com/nf-core/mhcquant/pull/447
🥲 1
j
I think it can be a strong recommendation, but nothing blocking? Some local modules will be more intimately integrated into a pipeline, in ways that hinder re-usability
👍 2
j
Agreed, but most of these look generically useful and/ or relate to suites with other tools in nf-core/modules
(for proteomics folks)
j
In the past we've not blocked an imminent release, but threatened blocking reviews for subsequent releases
👍 2
E.g. for first releases letting it slide but more mature pipelines 'should know better ' at that point
j
No worries @Jonathan Manning 🙂. Happy to get attention in that regard. I already worked on porting lots of proteomics modules to nf-core basically on my own.. https://github.com/nf-core/mhcquant/issues/296. Time is the constraint here since I kind of balance my time with improving and maintaining #CE9BJ6X6V #CED0U30KD and #CFVDZCA23 , I would love to see more people contributing / help porting modules to nf-core
👍 1
f
One idea: open multiple issues for tool suites in these pipelines on the modules repo and explain that they "just" need porting (so good for newcomers as well or people that want to try things out). Then its visible on that repo.
💡 2
👍 1
j
That's a really really good idea!
Particularly for Hackathonsn
👍 1